Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a919e72 authored by Linus Walleij's avatar Linus Walleij Committed by Greg Kroah-Hartman
Browse files

net: dsa: rtl8366: Skip PVID setting if not requested 



[ Upstream commit 3dfe8dde093a07e82fa472c0f8c29a7f6a2006a5 ]

We go to lengths to determine whether the PVID should be set
for this port or not, and then fail to take it into account.
Fix this oversight.

Fixes: d8652956 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 999c5c5f

drivers/net/dsa/rtl8366.c

+3 −0
Original line number Diff line number Diff line
@@ -436,6 +436,9 @@ void rtl8366_vlan_add(struct dsa_switch *ds, int port, 
				"failed to set up VLAN %04x",

				vid);



		if (!pvid)

			continue;



		ret = rtl8366_set_pvid(smi, port, vid);

		if (ret)

			dev_err(smi->dev,