Commit 2a16fc93 authored Jun 12, 2014 by Viresh Kumar Committed by Frederic Weisbecker Aug 22, 2014

nohz: Avoid tick's double reprogramming in highres mode



In highres mode, the tick reschedules itself unconditionally to the
next jiffies.

However while this clock reprogramming is relevant when the tick is
in periodic mode, it's not that interesting when we run in dynticks mode
because irq exit is likely going to overwrite the next tick to some
randomly deferred future.

So lets just get rid of this tick self rescheduling in dynticks mode.
This way we can avoid some clockevents double write in favourable
scenarios like when we stop the tick completely in idle while no other
hrtimer is pending.

Suggested-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

parent b5e995e6

kernel/time/tick-sched.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1099,6 +1099,10 @@ static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
		if (regs)
		tick_sched_handle(ts, regs);

		/* No need to reprogram if we are in idle or full dynticks mode */
		if (unlikely(ts->tick_stopped))
		return HRTIMER_NORESTART;

		hrtimer_forward(timer, now, tick_period);

		return HRTIMER_RESTART;