Commit 29f65339 authored Mar 16, 2018 by Dan Carpenter Committed by Greg Kroah-Hartman Mar 16, 2018

usb: xhci: Clean up error code in xhci_dbc_tty_register_device()

tty_port_register_device() returns error pointers on error, never NULL.
The IS_ERR_OR_NULL() function returns either 1 or 0 so it means we
return 1 on error instead of a proper error code. The caller only
checks for zero vs non-zero so this doesn't affect runtime.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 95713fb8

drivers/usb/host/xhci-dbgtty.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -443,9 +443,10 @@ int xhci_dbc_tty_register_device(struct xhci_hcd *xhci)
		xhci_dbc_tty_init_port(xhci, port);
		tty_dev = tty_port_register_device(&port->port,
		dbc_tty_driver, 0, NULL);
		ret = IS_ERR_OR_NULL(tty_dev);
		if (ret)
		if (IS_ERR(tty_dev)) {
		ret = PTR_ERR(tty_dev);
		goto register_fail;
		}

		ret = kfifo_alloc(&port->write_fifo, DBC_WRITE_BUF_SIZE, GFP_KERNEL);
		if (ret)