Commit 2997bfd0 authored May 23, 2016 by Dan Carpenter Committed by Anna Schumaker May 25, 2016

NFS: checking for NULL instead of IS_ERR() in nfs_commit_file()



nfs_create_request() doesn't return NULL, it returns error pointers.

Fixes: 67911c8f ('NFS: Add nfs_commit_file()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 1b3c6d07

fs/nfs/write.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1735,8 +1735,8 @@ int nfs_commit_file(struct file file, struct nfs_write_verifier verf)

		open = get_nfs_open_context(nfs_file_open_context(file));
		req = nfs_create_request(open, NULL, NULL, 0, i_size_read(inode));
		if (!req) {
		ret = -ENOMEM;
		if (IS_ERR(req)) {
		ret = PTR_ERR(req);
		goto out_put;
		}