Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29898ad7 authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Greg Kroah-Hartman
Browse files

nfs: we don't support removing system.nfs4_acl 



[ Upstream commit 4f8be1f53bf615102d103c0509ffa9596f65b718 ]

The NFSv4 protocol doesn't have any notion of reomoving an attribute, so
removexattr(path,"system.nfs4_acl") doesn't make sense.

There's no documented return value.  Arguably it could be EOPNOTSUPP but
I'm a little worried an application might take that to mean that we
don't support ACLs or xattrs.  How about EINVAL?

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 68a3d21d

fs/nfs/nfs4proc.c

+3 −0
Original line number Diff line number Diff line
@@ -5535,6 +5535,9 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl 
	unsigned int npages = DIV_ROUND_UP(buflen, PAGE_SIZE);

	int ret, i;



	/* You can't remove system.nfs4_acl: */

	if (buflen == 0)

		return -EINVAL;

	if (!nfs4_server_supports_acls(server))

		return -EOPNOTSUPP;

	if (npages > ARRAY_SIZE(pages))