Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 297a6961 authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller
Browse files

net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()



platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ecb10288
Loading
Loading
Loading
Loading
+2 −0
Original line number Original line Diff line number Diff line
@@ -205,6 +205,8 @@ static int unimac_mdio_probe(struct platform_device *pdev)
		return -ENOMEM;
		return -ENOMEM;


	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	if (!r)
		return -EINVAL;


	/* Just ioremap, as this MDIO block is usually integrated into an
	/* Just ioremap, as this MDIO block is usually integrated into an
	 * Ethernet MAC controller register range
	 * Ethernet MAC controller register range