Commit 29756174 authored Jul 22, 2015 by Greg Kroah-Hartman

greybus: connection: prevent oops for protocol_id sysfs file



If we don't have a protocol assigned to a connection, don't oops when
trying to read the "protocol_id" sysfs file.

Fixes Jira SW-968.

Reported-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

parent 155b9f17

drivers/staging/greybus/connection.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -80,7 +80,10 @@ protocol_id_show(struct device dev, struct device_attribute attr, char *buf)
		{
		struct gb_connection *connection = to_gb_connection(dev);

		if (connection->protocol)
		return sprintf(buf, "%d\n", connection->protocol->id);
		else
		return -EINVAL;
		}
		static DEVICE_ATTR_RO(protocol_id);