Commit 29750821 authored Apr 22, 2015 by Namhyung Kim Committed by Arnaldo Carvalho de Melo May 05, 2015

perf tools: Move TUI-specific fields into unnamed union

Since perf diff only supports stdio output, TUI fields are only accessed
from perf report (or perf top).  So add a new unnamed union and move
struct hist_entry_tui and those TUI-specific fields.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1429687101-4360-2-git-send-email-namhyung@kernel.org

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent a923e2c4

tools/perf/util/sort.h

+12 −6

Original line number	Diff line number	Diff line
		@@ -93,18 +93,24 @@ struct hist_entry {
		s32 cpu;
		u8 cpumode;

		struct hist_entry_diff diff;

		/* We are added by hists__add_dummy_entry. */
		bool dummy;

		/* XXX These two should move to some tree widget lib */
		u16 row_offset;
		u16 nr_rows;

		bool init_have_children;
		char level;
		u8 filtered;
		union {
		/*
		* Since perf diff only supports the stdio output, TUI
		* fields are only accessed from perf report (or perf
		* top). So make it an union to reduce memory usage.
		*/
		struct hist_entry_diff diff;
		struct /* for TUI */ {
		u16 row_offset;
		u16 nr_rows;
		};
		};
		char *srcline;
		struct symbol *parent;
		struct rb_root sorted_chain;