Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29479ed3 authored by Lyude Paul's avatar Lyude Paul Committed by Greg Kroah-Hartman
Browse files

drm/edid: Fix uninitialized variable in drm_cvt_modes() 



commit 991fcb77f490390bcad89fa67d95763c58cdc04c upstream.

Noticed this when trying to compile with -Wall on a kernel fork. We
potentially don't set width here, which causes the compiler to complain
about width potentially being uninitialized in drm_cvt_modes(). So, let's
fix that.

Changes since v1:
* Don't emit an error as this code isn't reachable, just mark it as such
Changes since v2:
* Remove now unused variable

Fixes: 3f649ab728cd ("treewide: Remove uninitialized_var() usage")
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Reviewed-by: default avatarIlia Mirkin <imirkin@alum.mit.edu>
Link: https://patchwork.freedesktop.org/patch/msgid/20201105235703.1328115-1-lyude@redhat.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7f683f28

drivers/gpu/drm/drm_edid.c

+2 −0
Original line number Diff line number Diff line
@@ -2798,6 +2798,8 @@ static int drm_cvt_modes(struct drm_connector *connector, 
		case 0x0c:

			width = height * 15 / 9;

			break;

		default:

			unreachable();

		}



		for (j = 1; j < 5; j++) {