Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 290fb763 authored by Arend van Spriel's avatar Arend van Spriel Committed by John W. Linville
Browse files

brcmfmac: no flow-control tlv signals when fcmode is NONE 



The fcmode provided by module parameter defaults to NONE, which
means no flow-control is required. In this case flow-control
signals should not be enabled.

Reviewed-by: default avatarPieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: default avatarPiotr Haber <phaber@broadcom.com>
Reviewed-by: default avatarHante Meuleman <meuleman@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 47829f4f

drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c

+6 −6
Original line number Diff line number Diff line
@@ -1221,16 +1221,12 @@ void brcmf_fws_del_interface(struct brcmf_if *ifp) 


int brcmf_fws_init(struct brcmf_pub *drvr)

{

	u32 tlv = 0;

	u32 tlv = BRCMF_FWS_FLAGS_RSSI_SIGNALS;

	int rc;



	if (!drvr->fw_signals)

		return 0;



	tlv = BRCMF_FWS_FLAGS_RSSI_SIGNALS |

	      BRCMF_FWS_FLAGS_XONXOFF_SIGNALS |

	      BRCMF_FWS_FLAGS_CREDIT_STATUS_SIGNALS;



	spin_lock_init(&drvr->fws_spinlock);



	drvr->fws = kzalloc(sizeof(*(drvr->fws)), GFP_KERNEL);
@@ -1243,7 +1239,11 @@ int brcmf_fws_init(struct brcmf_pub *drvr) 
	drvr->fws->drvr = drvr;

	drvr->fws->fcmode = fcmode;



	/* enable proptxtstatus signaling by default */

	/* enable firmware signalling if fcmode active */

	if (drvr->fws->fcmode != BRCMF_FWS_FCMODE_NONE)

		tlv |= BRCMF_FWS_FLAGS_XONXOFF_SIGNALS |

		       BRCMF_FWS_FLAGS_CREDIT_STATUS_SIGNALS;



	rc = brcmf_fil_iovar_int_set(drvr->iflist[0], "tlv", tlv);

	if (rc < 0) {

		brcmf_err("failed to set bdcv2 tlv signaling\n");