Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28bcd199 authored by Chandrabhanu Mahapatra's avatar Chandrabhanu Mahapatra Committed by Tomi Valkeinen
Browse files

OMAPDSS: Remove dss_debug variable 



All the debug prints have been replaced with pr_debug(). Thus, the dependency on
dss_debug variable is replaced with dyndbg in dynamic debugging mode and DEBUG
flag otherwise. So, the dss_debug variable is removed along with checks for
DEBUG flag.

Signed-off-by: default avatarChandrabhanu Mahapatra <cmahapatra@ti.com>
Reviewed-by: default avatarSumit Semwal <sumit.semwal@ti.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent f30be7d3

drivers/video/omap2/dss/core.c

+0 −5
Original line number Diff line number Diff line
@@ -53,11 +53,6 @@ static char *def_disp_name; 
module_param_named(def_disp, def_disp_name, charp, 0);

MODULE_PARM_DESC(def_disp, "default display name");



#ifdef DEBUG

bool dss_debug;

module_param_named(debug, dss_debug, bool, 0644);

#endif



const char *dss_get_default_display_name(void)

{

	return core.default_display_name;

drivers/video/omap2/dss/dispc.c

+2 −6
Original line number Diff line number Diff line
@@ -3669,7 +3669,6 @@ int omap_dispc_unregister_isr(omap_dispc_isr_t isr, void *arg, u32 mask) 
}

EXPORT_SYMBOL(omap_dispc_unregister_isr);



#ifdef DEBUG

static void print_irq_status(u32 status)

{

	if ((status & dispc.irq_error_mask) == 0)
@@ -3690,7 +3689,6 @@ static void print_irq_status(u32 status) 
		dss_has_feature(FEAT_MGR_LCD3) ? PIS(SYNC_LOST3) : "");

#undef PIS

}

#endif



/* Called from dss.c. Note that we don't touch clocks here,

 * but we presume they are on because we got an IRQ. However,
@@ -3723,10 +3721,8 @@ static irqreturn_t omap_dispc_irq_handler(int irq, void *arg) 
	spin_unlock(&dispc.irq_stats_lock);

#endif



#ifdef DEBUG

	if (dss_debug)

	print_irq_status(irqstatus);

#endif



	/* Ack the interrupt. Do it here before clocks are possibly turned

	 * off */

	dispc_write_reg(DISPC_IRQSTATUS, irqstatus);

drivers/video/omap2/dss/dsi.c

+0 −7
Original line number Diff line number Diff line
@@ -1095,15 +1095,11 @@ static inline void dsi_enable_pll_clock(struct platform_device *dsidev, 
	}

}



#ifdef DEBUG

static void _dsi_print_reset_status(struct platform_device *dsidev)

{

	u32 l;

	int b0, b1, b2;



	if (!dss_debug)

		return;



	/* A dummy read using the SCP interface to any DSIPHY register is

	 * required after DSIPHY reset to complete the reset of the DSI complex

	 * I/O. */
@@ -1134,9 +1130,6 @@ static void _dsi_print_reset_status(struct platform_device *dsidev) 


#undef DSI_FLD_GET

}

#else

#define _dsi_print_reset_status(x)

#endif



static inline int dsi_if_enable(struct platform_device *dsidev, bool enable)

{

drivers/video/omap2/dss/dss.h

+0 −4
Original line number Diff line number Diff line
@@ -23,10 +23,6 @@ 
#ifndef __OMAP2_DSS_H

#define __OMAP2_DSS_H



#ifdef DEBUG

extern bool dss_debug;

#endif



#ifdef pr_fmt

#undef pr_fmt

#endif