Commit 287debd6 authored Jun 16, 2016 by Arnd Bergmann Committed by David S. Miller Jun 16, 2016

net: qlcnic: don't set unused function argument

We get a warning for qlcnic_83xx_get_mac_address when building with
"make W=1":

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function 'qlcnic_83xx_get_mac_address':
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: error: parameter 'function' set but not used [-Werror=unused-but-set-parameter]

Clearly this is harmless, but there is also no point for setting
the variable, so we can simply remove the assignment.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 55e7f6ab

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2159,7 +2159,6 @@ int qlcnic_83xx_get_mac_address(struct qlcnic_adapter adapter, u8 mac,
		struct qlcnic_cmd_args cmd;
		u32 mac_low, mac_high;

		function = 0;
		err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_MAC_ADDRESS);
		if (err)
		return err;