Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2809508d authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: isp1362: remove unused _WARN_ON() calls 



Like _BUG_ON(), _WARN_ON() wasn't ever being used, so just delete it, as
obviously things are working properly now (if not, we have bigger
problems...)

Acked-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 051a0689

drivers/usb/host/isp1362.h

+0 −9
Original line number Original line Diff line number Diff line
@@ -91,8 +91,6 @@ typedef const unsigned int isp1362_reg_t; 




#define ISP1362_REG_NO(r)		((r) & REG_NO_MASK)

#define ISP1362_REG_NO(r)		((r) & REG_NO_MASK)





#define _WARN_ON(x)	WARN_ON(x)



#define ISP1362_REG(name, addr, width, rw) \

#define ISP1362_REG(name, addr, width, rw) \

static isp1362_reg_t ISP1362_REG_##name = ((addr) | (width) | (rw))

static isp1362_reg_t ISP1362_REG_##name = ((addr) | (width) | (rw))
@@ -101,7 +99,6 @@ static isp1362_reg_t ISP1362_REG_##name = ((addr) | (width) | (rw)) 
#else

#else

typedef const unsigned char isp1362_reg_t;

typedef const unsigned char isp1362_reg_t;

#define ISP1362_REG_NO(r)		(r)

#define ISP1362_REG_NO(r)		(r)

#define _WARN_ON(x)			do {} while (0)





#define ISP1362_REG(name, addr, width, rw) \

#define ISP1362_REG(name, addr, width, rw) \

static isp1362_reg_t ISP1362_REG_##name = addr

static isp1362_reg_t ISP1362_REG_##name = addr
@@ -926,14 +923,11 @@ static void isp1362_read_buffer(struct isp1362_hcd *isp1362_hcd, void *buf, u16 
	    __func__, len, offset, buf);

	    __func__, len, offset, buf);





	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	_WARN_ON((isp1362_read_reg16(isp1362_hcd, HCuPINT) & HCuPINT_EOT));





	isp1362_write_addr(isp1362_hcd, ISP1362_REG_HCDIRDATA);

	isp1362_write_addr(isp1362_hcd, ISP1362_REG_HCDIRDATA);





	isp1362_read_fifo(isp1362_hcd, buf, len);

	isp1362_read_fifo(isp1362_hcd, buf, len);

	_WARN_ON(!(isp1362_read_reg16(isp1362_hcd, HCuPINT) & HCuPINT_EOT));

	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	_WARN_ON((isp1362_read_reg16(isp1362_hcd, HCuPINT) & HCuPINT_EOT));

}

}





static void isp1362_write_buffer(struct isp1362_hcd *isp1362_hcd, void *buf, u16 offset, int len)

static void isp1362_write_buffer(struct isp1362_hcd *isp1362_hcd, void *buf, u16 offset, int len)
@@ -944,14 +938,11 @@ static void isp1362_write_buffer(struct isp1362_hcd *isp1362_hcd, void *buf, u16 
	    __func__, len, offset, buf);

	    __func__, len, offset, buf);





	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	_WARN_ON((isp1362_read_reg16(isp1362_hcd, HCuPINT) & HCuPINT_EOT));





	isp1362_write_addr(isp1362_hcd, ISP1362_REG_HCDIRDATA | ISP1362_REG_WRITE_OFFSET);

	isp1362_write_addr(isp1362_hcd, ISP1362_REG_HCDIRDATA | ISP1362_REG_WRITE_OFFSET);

	isp1362_write_fifo(isp1362_hcd, buf, len);

	isp1362_write_fifo(isp1362_hcd, buf, len);





	_WARN_ON(!(isp1362_read_reg16(isp1362_hcd, HCuPINT) & HCuPINT_EOT));

	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	isp1362_write_reg16(isp1362_hcd, HCuPINT, HCuPINT_EOT);

	_WARN_ON((isp1362_read_reg16(isp1362_hcd, HCuPINT) & HCuPINT_EOT));

}

}





static void __attribute__((unused)) dump_data(char *buf, int len)

static void __attribute__((unused)) dump_data(char *buf, int len)