Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27e9e0f1 authored by Bart Van Assche's avatar Bart Van Assche Committed by James Bottomley
Browse files

[SCSI] remove a useless get/put_device pair in scsi_next_command 



Eliminate a get_device() / put_device() pair from scsi_next_command().
Both are atomic operations hence removing these slightly improves
performance.

[hch: slight changes due to different context]
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 613be1f6

drivers/scsi/scsi_lib.c

+0 −5
Original line number Diff line number Diff line
@@ -526,14 +526,9 @@ void scsi_next_command(struct scsi_cmnd *cmd) 
	struct scsi_device *sdev = cmd->device;

	struct request_queue *q = sdev->request_queue;



	/* need to hold a reference on the device before we let go of the cmd */

	get_device(&sdev->sdev_gendev);



	scsi_put_command(cmd);

	put_device(&sdev->sdev_gendev);

	scsi_run_queue(q);



	/* ok to remove device now */

	put_device(&sdev->sdev_gendev);

}