Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27143c71 authored by Xiao Ni's avatar Xiao Ni Committed by Greg Kroah-Hartman
Browse files

It's wrong to add len to sector_nr in raid10 reshape twice 



commit b761dcf1217760a42f7897c31dcb649f59b2333e upstream.

In reshape_request it already adds len to sector_nr already. It's wrong to add len to
sector_nr again after adding pages to bio. If there is bad block it can't copy one chunk
at a time, it needs to goto read_more. Now the sector_nr is wrong. It can cause data
corruption.

Cc: stable@vger.kernel.org # v3.16+
Signed-off-by: default avatarXiao Ni <xni@redhat.com>
Signed-off-by: default avatarSong Liu <songliubraving@fb.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d6b577c6

drivers/md/raid10.c

+0 −1
Original line number Diff line number Diff line
@@ -4630,7 +4630,6 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, 
	atomic_inc(&r10_bio->remaining);

	read_bio->bi_next = NULL;

	generic_make_request(read_bio);

	sector_nr += nr_sectors;

	sectors_done += nr_sectors;

	if (sector_nr <= last)

		goto read_more;