Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26fce055 authored by Leonard Crestez's avatar Leonard Crestez Committed by Philipp Zabel
Browse files

reset: imx7: Fix always writing bits as 0 



Right now the only user of reset-imx7 is pci-imx6 and the
reset_control_assert and deassert calls on pciephy_reset don't toggle
the PCIEPHY_BTN and PCIEPHY_G_RST bits as expected. Fix this by writing
1 or 0 respectively.

The reference manual is not very clear regarding SRC_PCIEPHY_RCR but for
other registers like MIPIPHY and HSICPHY the bits are explicitly
documented as "1 means assert, 0 means deassert".

The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN.

Signed-off-by: default avatarLeonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent ce397d21

drivers/reset/reset-imx7.c

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ static int imx7_reset_set(struct reset_controller_dev *rcdev, 
{

	struct imx7_src *imx7src = to_imx7_src(rcdev);

	const struct imx7_src_signal *signal = &imx7_src_signals[id];

	unsigned int value = 0;

	unsigned int value = assert ? signal->bit : 0;



	switch (id) {

	case IMX7_RESET_PCIEPHY: