Commit 26d15948 authored Aug 15, 2017 by Zhu Yanjun Committed by David S. Miller Aug 15, 2017

mlx5: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not necessary to manually clear the
device driver data to NULL.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e084a8b8

drivers/net/ethernet/mellanox/mlx5/core/main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1400,7 +1400,6 @@ static int init_one(struct pci_dev *pdev,
		cleanup_srcu_struct(&priv->pfault_srcu);
		clean_dev:
		#endif
		pci_set_drvdata(pdev, NULL);
		devlink_free(devlink);

		return err;
		@@ -1427,7 +1426,6 @@ static void remove_one(struct pci_dev *pdev)
		#ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING
		cleanup_srcu_struct(&priv->pfault_srcu);
		#endif
		pci_set_drvdata(pdev, NULL);
		devlink_free(devlink);
		}