Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 264813ac authored by Liu Bo's avatar Liu Bo Committed by David Sterba
Browse files

Btrfs: fix invalid reference in replace_path 



Dan Carpenter's static checker has found this error, it's introduced by
commit 64c043de
("Btrfs: fix up read_tree_block to return proper error")

It's really supposed to 'break' the loop on error like others.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 2a162ce9

fs/btrfs/relocation.c

+1 −0
Original line number Diff line number Diff line
@@ -1850,6 +1850,7 @@ int replace_path(struct btrfs_trans_handle *trans, 
			eb = read_tree_block(dest, old_bytenr, old_ptr_gen);

			if (IS_ERR(eb)) {

				ret = PTR_ERR(eb);

				break;

			} else if (!extent_buffer_uptodate(eb)) {

				ret = -EIO;

				free_extent_buffer(eb);