Commit 25f6e89b authored Jul 30, 2009 by Bartlomiej Zolnierkiewicz Committed by Ingo Molnar Aug 02, 2009

x86: Remove superfluous NULL pointer check in destroy_irq()



This takes care of the following entry from Dan's list:

  arch/x86/kernel/apic/io_apic.c +3241 destroy_irq(11) warning: variable derefenced before check 'desc'

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Eugene Teo <eteo@redhat.com>
Cc: Julia Lawall <julia@diku.dk>
LKML-Reference: <200907302321.19086.bzolnier@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent e25371d6

arch/x86/kernel/apic/io_apic.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -3185,7 +3185,6 @@ void destroy_irq(unsigned int irq)
		cfg = desc->chip_data;
		dynamic_irq_cleanup(irq);
		/* connect back irq_cfg */
		if (desc)
		desc->chip_data = cfg;

		free_irte(irq);