Commit 25ad1cbd authored May 24, 2018 by Ronnie Sahlberg Committed by Steve French May 30, 2018

cifs: return error on invalid value written to cifsFYI



RHBZ: 1539617

Check that, if it is not a boolean, the value the user tries
to write to /proc/fs/cifs/cifsFYI is valid and return an error
if not.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reported-by: Xiaoli Feng <xifeng@redhat.com>

parent 57c55cd7

fs/cifs/cifs_debug.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -584,6 +584,8 @@ static ssize_t cifsFYI_proc_write(struct file file, const char __user buffer,
	cifsFYI = bv;		cifsFYI = bv;
	else if ((c[0] > '1') && (c[0] <= '9'))		else if ((c[0] > '1') && (c[0] <= '9'))
	cifsFYI = (int) (c[0] - '0'); /* see cifs_debug.h for meanings */		cifsFYI = (int) (c[0] - '0'); /* see cifs_debug.h for meanings */
			else
			return -EINVAL;

	return count;		return count;
	}		}