Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2538bbb0 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()' 



[ Upstream commit b28cc6cec3d814f5184cbebb2d1f987e769f534a ]

In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Commit e115a2bf has modified more than what is said in the commit
message. Reverse part of it znd return an error when needed, as it was
previously.

Fixes: e115a2bf ("rtc: max77686: stop validating rtc_time in .read_time")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent eb5b255e

drivers/rtc/rtc-max77686.c

+1 −1
Original line number Diff line number Diff line
@@ -360,7 +360,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) 


out:

	mutex_unlock(&info->lock);

	return 0;

	return ret;

}



static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)