Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 247bde13 authored by Thierry Reding's avatar Thierry Reding
Browse files

leds: pwm: Remove atomic code paths 



PWM devices have all been marked as "might sleep" since v4.5. It no
longer makes sense to keep the alternative code paths around because
it is effectively dead code.

Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 0c744ea4

drivers/leds/leds-pwm.c

+3 −13
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ struct led_pwm_data { 
	unsigned int		active_low;

	unsigned int		period;

	int			duty;

	bool			can_sleep;

};



struct led_pwm_priv {
@@ -49,7 +48,7 @@ static void __led_pwm_set(struct led_pwm_data *led_dat) 
		pwm_enable(led_dat->pwm);

}



static void led_pwm_set(struct led_classdev *led_cdev,

static int led_pwm_set(struct led_classdev *led_cdev,

		       enum led_brightness brightness)

{

	struct led_pwm_data *led_dat =
@@ -66,12 +65,7 @@ static void led_pwm_set(struct led_classdev *led_cdev, 
	led_dat->duty = duty;



	__led_pwm_set(led_dat);

}



static int led_pwm_set_blocking(struct led_classdev *led_cdev,

	enum led_brightness brightness)

{

	led_pwm_set(led_cdev, brightness);

	return 0;

}
@@ -112,11 +106,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, 
		return ret;

	}



	led_data->can_sleep = pwm_can_sleep(led_data->pwm);

	if (!led_data->can_sleep)

		led_data->cdev.brightness_set = led_pwm_set;

	else

		led_data->cdev.brightness_set_blocking = led_pwm_set_blocking;

	led_data->cdev.brightness_set_blocking = led_pwm_set;



	/*

	 * FIXME: pwm_apply_args() should be removed when switching to the