Commit 2401cbc0 authored Apr 29, 2024 by Ricardo Ribalda Committed by Greg Kroah-Hartman Jul 18, 2024

media: dvb-frontends: tda18271c2dd: Remove casting during div

[ Upstream commit e9a844632630e18ed0671a7e3467431bd719952e ]

do_div() divides 64 bits by 32. We were adding a casting to the divider
to 64 bits, for a number that fits perfectly in 32 bits. Remove it.

Found by cocci:
drivers/media/dvb-frontends/tda18271c2dd.c:355:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
drivers/media/dvb-frontends/tda18271c2dd.c:331:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-8-3c4865f5a4b0@chromium.org


Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 47d28dde

drivers/media/dvb-frontends/tda18271c2dd.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -345,7 +345,7 @@ static int CalcMainPLL(struct tda_state *state, u32 freq)

		OscFreq = (u64) freq * (u64) Div;
		OscFreq *= (u64) 16384;
		do_div(OscFreq, (u64)16000000);
		do_div(OscFreq, 16000000);
		MainDiv = OscFreq;

		state->m_Regs[MPD] = PostDiv & 0x77;
		@@ -369,7 +369,7 @@ static int CalcCalPLL(struct tda_state *state, u32 freq)
		OscFreq = (u64)freq * (u64)Div;
		/* CalDiv = u32( OscFreq * 16384 / 16000000 ); */
		OscFreq *= (u64)16384;
		do_div(OscFreq, (u64)16000000);
		do_div(OscFreq, 16000000);
		CalDiv = OscFreq;

		state->m_Regs[CPD] = PostDiv;