Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23e9c128 authored by Rafał Miłecki's avatar Rafał Miłecki Committed by Kalle Valo
Browse files

brcmfmac: fix memory leak in brcmf_fill_bss_param 



This function is called from get_station callback which means that every
time user space was getting/dumping station(s) we were leaking 2 KiB.

Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
Fixes: 1f0dc59a ("brcmfmac: rework .get_station() callback")
Cc: stable@vger.kernel.org # 4.2+
Acked-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent b42fbed6

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

+4 −1
Original line number Diff line number Diff line
@@ -2527,7 +2527,7 @@ static void brcmf_fill_bss_param(struct brcmf_if *ifp, struct station_info *si) 
				     WL_BSS_INFO_MAX);

	if (err) {

		brcmf_err("Failed to get bss info (%d)\n", err);

		return;

		goto out_kfree;

	}

	si->filled |= BIT(NL80211_STA_INFO_BSS_PARAM);

	si->bss_param.beacon_interval = le16_to_cpu(buf->bss_le.beacon_period);
@@ -2539,6 +2539,9 @@ static void brcmf_fill_bss_param(struct brcmf_if *ifp, struct station_info *si) 
		si->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_PREAMBLE;

	if (capability & WLAN_CAPABILITY_SHORT_SLOT_TIME)

		si->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_SLOT_TIME;



out_kfree:

	kfree(buf);

}



static s32