Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23c4a881 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Switch to polling mode before disabling MSI 



When any codec communication error happens, try to switch to the polling
mode first before turning off MSI.  MSI gets more stable nowadays, thus
we should keep it on as much as possible.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6a5f96ce

sound/pci/hda/hda_intel.c

+8 −8
Original line number Diff line number Diff line
@@ -677,6 +677,14 @@ static unsigned int azx_rirb_get_response(struct hda_bus *bus, 
		}

	}



	if (!chip->polling_mode) {

		snd_printk(KERN_WARNING SFX "azx_get_response timeout, "

			   "switching to polling mode: last cmd=0x%08x\n",

			   chip->last_cmd[addr]);

		chip->polling_mode = 1;

		goto again;

	}



	if (chip->msi) {

		snd_printk(KERN_WARNING SFX "No response from codec, "

			   "disabling MSI: last cmd=0x%08x\n",
@@ -692,14 +700,6 @@ static unsigned int azx_rirb_get_response(struct hda_bus *bus, 
		goto again;

	}



	if (!chip->polling_mode) {

		snd_printk(KERN_WARNING SFX "azx_get_response timeout, "

			   "switching to polling mode: last cmd=0x%08x\n",

			   chip->last_cmd[addr]);

		chip->polling_mode = 1;

		goto again;

	}



	if (chip->probing) {

		/* If this critical timeout happens during the codec probing

		 * phase, this is likely an access to a non-existing codec