Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 232a5adc authored by Michael Grzeschik's avatar Michael Grzeschik Committed by Mark Brown
Browse files

spi: bitbang: only toggle bitchanges 



The current implementation of bitbang_txrx_be_cpha0 and
bitbang_txrx_be_cpha1 always call setmosi. That runs into several
unnecessary calls into the gpiolib when the level of the GPIO actually
has not to be changed.

This patch changes the routines to remember the last GPIO level
and only calls setmosi if an change has to be made. This
way it improves the transfer throughput.

Signed-off-by: default avatarMichael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c517d838

drivers/spi/spi-bitbang-txrx.h

+14 −4
Original line number Diff line number Diff line
@@ -49,12 +49,17 @@ bitbang_txrx_be_cpha0(struct spi_device *spi, 
{

	/* if (cpol == 0) this is SPI_MODE_0; else this is SPI_MODE_2 */



	bool oldbit = !(word & 1);

	/* clock starts at inactive polarity */

	for (word <<= (32 - bits); likely(bits); bits--) {



		/* setup MSB (to slave) on trailing edge */

		if ((flags & SPI_MASTER_NO_TX) == 0)

		if ((flags & SPI_MASTER_NO_TX) == 0) {

			if ((word & (1 << 31)) != oldbit) {

				setmosi(spi, word & (1 << 31));

				oldbit = word & (1 << 31);

			}

		}

		spidelay(nsecs);	/* T(setup) */



		setsck(spi, !cpol);
@@ -76,13 +81,18 @@ bitbang_txrx_be_cpha1(struct spi_device *spi, 
{

	/* if (cpol == 0) this is SPI_MODE_1; else this is SPI_MODE_3 */



	bool oldbit = !(word & (1 << 31));

	/* clock starts at inactive polarity */

	for (word <<= (32 - bits); likely(bits); bits--) {



		/* setup MSB (to slave) on leading edge */

		setsck(spi, !cpol);

		if ((flags & SPI_MASTER_NO_TX) == 0)

		if ((flags & SPI_MASTER_NO_TX) == 0) {

			if ((word & (1 << 31)) != oldbit) {

				setmosi(spi, word & (1 << 31));

				oldbit = word & (1 << 31);

			}

		}

		spidelay(nsecs); /* T(setup) */



		setsck(spi, cpol);