Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2271150b authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller
Browse files

net: hns: fix device reference leaks 



Make sure to drop the reference taken by class_find_device() in
hnae_get_handle() on errors and when later releasing the handle.

Fixes: 6fe6611f ("net: add Hisilicon Network Subsystem...")
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6bed0118

drivers/net/ethernet/hisilicon/hns/hnae.c

+7 −1
Original line number Diff line number Diff line
@@ -332,8 +332,10 @@ struct hnae_handle *hnae_get_handle(struct device *owner_dev, 
		return ERR_PTR(-ENODEV);



	handle = dev->ops->get_handle(dev, port_id);

	if (IS_ERR(handle))

	if (IS_ERR(handle)) {

		put_device(&dev->cls_dev);

		return handle;

	}



	handle->dev = dev;

	handle->owner_dev = owner_dev;
@@ -356,6 +358,8 @@ struct hnae_handle *hnae_get_handle(struct device *owner_dev, 
	for (j = i - 1; j >= 0; j--)

		hnae_fini_queue(handle->qs[j]);



	put_device(&dev->cls_dev);



	return ERR_PTR(-ENOMEM);

}

EXPORT_SYMBOL(hnae_get_handle);
@@ -377,6 +381,8 @@ void hnae_put_handle(struct hnae_handle *h) 
		dev->ops->put_handle(h);



	module_put(dev->owner);



	put_device(&dev->cls_dev);

}

EXPORT_SYMBOL(hnae_put_handle);