Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22472769 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Felipe Balbi
Browse files

USB: gadget: pxa27x: Re-use DEFINE_SHOW_ATTRIBUTE() macro 



...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 5aaa036b

drivers/usb/gadget/udc/pxa27x_udc.c

+3 −39
Original line number Diff line number Diff line
@@ -131,6 +131,7 @@ static int state_dbg_show(struct seq_file *s, void *p) 


	return 0;

}

DEFINE_SHOW_ATTRIBUTE(state_dbg);



static int queues_dbg_show(struct seq_file *s, void *p)

{
@@ -163,6 +164,7 @@ static int queues_dbg_show(struct seq_file *s, void *p) 


	return 0;

}

DEFINE_SHOW_ATTRIBUTE(queues_dbg);



static int eps_dbg_show(struct seq_file *s, void *p)

{
@@ -199,45 +201,7 @@ static int eps_dbg_show(struct seq_file *s, void *p) 


	return 0;

}



static int eps_dbg_open(struct inode *inode, struct file *file)

{

	return single_open(file, eps_dbg_show, inode->i_private);

}



static int queues_dbg_open(struct inode *inode, struct file *file)

{

	return single_open(file, queues_dbg_show, inode->i_private);

}



static int state_dbg_open(struct inode *inode, struct file *file)

{

	return single_open(file, state_dbg_show, inode->i_private);

}



static const struct file_operations state_dbg_fops = {

	.owner		= THIS_MODULE,

	.open		= state_dbg_open,

	.llseek		= seq_lseek,

	.read		= seq_read,

	.release	= single_release,

};



static const struct file_operations queues_dbg_fops = {

	.owner		= THIS_MODULE,

	.open		= queues_dbg_open,

	.llseek		= seq_lseek,

	.read		= seq_read,

	.release	= single_release,

};



static const struct file_operations eps_dbg_fops = {

	.owner		= THIS_MODULE,

	.open		= eps_dbg_open,

	.llseek		= seq_lseek,

	.read		= seq_read,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(eps_dbg);



static void pxa_init_debugfs(struct pxa_udc *udc)

{