Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21d578aa authored by Mukesh Ojha's avatar Mukesh Ojha Committed by Srinivasarao P
Browse files

soc: qcom: dcc: Use sscanf instead of strlcpy 



When we write string on sysfs node it appends '\n' at the end which
modifies passed string. 'strlcpy' does not take care of removing '\n'
so use sscanf which truncate '\n' from the original string.

Change-Id: Id99124f380ad4dc3c9c0ffcaee045304f131844e
CRs-Fixed: 2193257
Signed-off-by: default avatarMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: default avatarSrinivasarao P <spathi@codeaurora.org>
parent 0b5ccb81

drivers/soc/qcom/dcc.c

+4 −2
Original line number Diff line number Diff line
@@ -548,7 +548,8 @@ static ssize_t func_type_store(struct device *dev, 
	if (strlen(buf) >= 10)

		return -EINVAL;



	strlcpy(str, buf, sizeof(str));

	if (sscanf(buf, "%9s", str) != 1)

		return -EINVAL;



	mutex_lock(&drvdata->mutex);

	if (drvdata->enable) {
@@ -592,7 +593,8 @@ static ssize_t data_sink_store(struct device *dev, 
	if (strlen(buf) >= 10)

		return -EINVAL;



	strlcpy(str, buf, sizeof(str));

	if (sscanf(buf, "%9s", str) != 1)

		return -EINVAL;



	mutex_lock(&drvdata->mutex);

	if (drvdata->enable) {