Commit 21a95683 authored Jan 03, 2021 by Dinghao Liu Committed by Greg Kroah-Hartman Mar 30, 2021

ixgbe: Fix memleak in ixgbe_configure_clsu32



[ Upstream commit 7a766381634da19fc837619b0a34590498d9d29a ]

When ixgbe_fdir_write_perfect_filter_82599() fails,
input allocated by kzalloc() has not been freed,
which leads to memleak.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e552465a

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -9487,7 +9487,9 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter,
		ixgbe_atr_compute_perfect_hash_82599(&input->filter, mask);
		err = ixgbe_fdir_write_perfect_filter_82599(hw, &input->filter,
		input->sw_idx, queue);
		if (!err)
		if (err)
		goto err_out_w_lock;

		ixgbe_update_ethtool_fdir_entry(adapter, input, input->sw_idx);
		spin_unlock(&adapter->fdir_perfect_lock);