Commit 21a190b9 authored Apr 08, 2016 by Denys Vlasenko Committed by Brian Norris Jul 09, 2016

mtd: cfi_cmdset_0020: Deinline do_write_buffer, save 5316 bytes



This function compiles to 2554 bytes of machine code.
In C, the function is almost 200 lines long.

It has only one callsite, but forced inlining that much code
makes gcc generate significantly worse code. Let gcc itself decide
what to do.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: David Woodhouse <David.Woodhouse@intel.com>
CC: Dan Carpenter <dan.carpenter@oracle.com>
CC: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
CC: linux-mtd@lists.infradead.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent 8bf66b24

drivers/mtd/chips/cfi_cmdset_0020.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -416,7 +416,7 @@ static int cfi_staa_read (struct mtd_info *mtd, loff_t from, size_t len, size_t
		return ret;
		}

		static inline int do_write_buffer(struct map_info map, struct flchip chip,
		static int do_write_buffer(struct map_info map, struct flchip chip,
		unsigned long adr, const u_char *buf, int len)
		{
		struct cfi_private *cfi = map->fldrv_priv;