Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 212b9a2c authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: serial: kl5kusb105: fix memleak on open 



commit 3f203f057edfcf6bd02c6b942799262bfcf31f73 upstream.

Fix memory leak of control-message transfer buffer on successful open().

Fixes: 6774d5f5 ("USB: serial: kl5kusb105: fix open error path")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 974c9391

drivers/usb/serial/kl5kusb105.c

+4 −6
Original line number Diff line number Diff line
@@ -276,12 +276,12 @@ static int klsi_105_open(struct tty_struct *tty, struct usb_serial_port *port) 
	priv->cfg.unknown2 = cfg->unknown2;

	spin_unlock_irqrestore(&priv->lock, flags);



	kfree(cfg);



	/* READ_ON and urb submission */

	rc = usb_serial_generic_open(tty, port);

	if (rc) {

		retval = rc;

		goto err_free_cfg;

	}

	if (rc)

		return rc;



	rc = usb_control_msg(port->serial->dev,

			     usb_sndctrlpipe(port->serial->dev, 0),
@@ -324,8 +324,6 @@ static int klsi_105_open(struct tty_struct *tty, struct usb_serial_port *port) 
			     KLSI_TIMEOUT);

err_generic_close:

	usb_serial_generic_close(port);

err_free_cfg:

	kfree(cfg);



	return retval;

}