Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20f02d66 authored by Valentin Rothberg's avatar Valentin Rothberg Committed by Dmitry Torokhov
Browse files

Input: tc3589x-keypad - set IRQF_ONESHOT flag to ensure IRQ request 



Since commit 1c6c6952 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

Currently, plat->irqtype is only set to IRQF_TRIGGER_FALLING.  This
patch sets the ONESHOT flag directly in request_threaded_irq() to
enforce the flag without being affected by future changes to
plat->irqtype.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Signed-off-by: default avatarValentin Rothberg <Valentin.Rothberg@lip6.fr>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 93050db2

drivers/input/keyboard/tc3589x-keypad.c

+3 −3
Original line number Diff line number Diff line
@@ -411,8 +411,8 @@ static int tc3589x_keypad_probe(struct platform_device *pdev) 


	input_set_drvdata(input, keypad);



	error = request_threaded_irq(irq, NULL,

			tc3589x_keypad_irq, plat->irqtype,

	error = request_threaded_irq(irq, NULL, tc3589x_keypad_irq,

				     plat->irqtype | IRQF_ONESHOT,

				     "tc3589x-keypad", keypad);

	if (error < 0) {

		dev_err(&pdev->dev,