Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 208afec4 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] dc395x: uninitialized variable in device_alloc() 



This bug was introduced back in bitkeeper days in 2003.  We use
"dcb->dev_mode" before it has been initialized.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarOliver Neukum <oliver@neukum.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 4d24834d

drivers/scsi/dc395x.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -3747,13 +3747,13 @@ static struct DeviceCtlBlk *device_alloc(struct AdapterCtlBlk *acb, 
	dcb->max_command = 1;

	dcb->max_command = 1;

	dcb->target_id = target;

	dcb->target_id = target;

	dcb->target_lun = lun;

	dcb->target_lun = lun;

	dcb->dev_mode = eeprom->target[target].cfg0;

#ifndef DC395x_NO_DISCONNECT

#ifndef DC395x_NO_DISCONNECT

	dcb->identify_msg =

	dcb->identify_msg =

	    IDENTIFY(dcb->dev_mode & NTC_DO_DISCONNECT, lun);

	    IDENTIFY(dcb->dev_mode & NTC_DO_DISCONNECT, lun);

#else

#else

	dcb->identify_msg = IDENTIFY(0, lun);

	dcb->identify_msg = IDENTIFY(0, lun);

#endif

#endif

	dcb->dev_mode = eeprom->target[target].cfg0;

	dcb->inquiry7 = 0;

	dcb->inquiry7 = 0;

	dcb->sync_mode = 0;

	dcb->sync_mode = 0;

	dcb->min_nego_period = clock_period[period_index];

	dcb->min_nego_period = clock_period[period_index];