Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2072fe51 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Inki Dae
Browse files

drm/exynos: Use VIDEO_SAMSUNG_S5P_G2D=n as G2D Kconfig dependency



Commit 254d4d11 ("drm/exynos: Add dependency for G2D in Kconfig") made
the DRM_EXYNOS_G2D symbol to only be selectable if the s5p-g2d V4L2 driver
is not enabled, since both use the same HW IP block.

But added the dependency as depends on !VIDEO_SAMSUNG_S5P_G2D which isn't
correct since Kconfig expressions are not boolean but tristate. So it will
only evaluate to 'n' if VIDEO_SAMSUNG_S5P_G2D=y but it will evaluate to m
if VIDEO_SAMSUNG_S5P_G2D=m.

This means that both the V4L2 and DRM drivers can be enabled if the former
is enabled as a module, which is not what we want.

Signed-off-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 36ffc2bd
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ comment "Sub-drivers"

config DRM_EXYNOS_G2D
	bool "G2D"
	depends on !VIDEO_SAMSUNG_S5P_G2D
	depends on VIDEO_SAMSUNG_S5P_G2D=n
	select FRAME_VECTOR
	help
	  Choose this option if you want to use Exynos G2D for DRM.