Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1fc98d11 authored by Andrey Vagin's avatar Andrey Vagin Committed by Linus Torvalds
Browse files

fsnotify/fdinfo: use named constants instead of hardcoded values 



MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64
bytes, so exportfs_encode_inode_fh can return an error.

Signed-off-by: default avatarAndrey Vagin <avagin@openvz.org>
Acked-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent acbbe6fb

fs/notify/fdinfo.c

+2 −2
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode *inode) 
{

	struct {

		struct file_handle handle;

		u8 pad[64];

		u8 pad[MAX_HANDLE_SZ];

	} f;

	int size, ret, i;
@@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode *inode) 
	size = f.handle.handle_bytes >> 2;



	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);

	if ((ret == 255) || (ret == -ENOSPC)) {

	if ((ret == FILEID_INVALID) || (ret == -ENOSPC)) {

		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);

		return 0;

	}