Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f563a6a authored by Thomas Hellstrom's avatar Thomas Hellstrom
Browse files

drm/vmwgfx: Don't use memory accounting for kernel-side fence objects 



Kernel side fence objects are used when unbinding resources and may thus be
created as part of a memory reclaim operation. This might trigger recursive
memory reclaims and result in the kernel running out of stack space.

So a simple way out is to avoid accounting of these fence objects.
In principle this is OK since while user-space can trigger the creation of
such objects, it can't really hold on to them. However, their lifetime is
quite long, so some form of accounting should perhaps be implemented in the
future.

Fixes kernel crashes when running, for example viewperf11 ensight-04 test 3
with low system memory settings.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: default avatarJakob Bornecrantz <jakob@vmware.com>
Reviewed-by: default avatarSinclair Yeh <syeh@vmware.com>
parent e338c4c2

drivers/gpu/drm/vmwgfx/vmwgfx_fence.c

+2 −20
Original line number Diff line number Diff line
@@ -545,35 +545,19 @@ void vmw_fence_obj_flush(struct vmw_fence_obj *fence) 


static void vmw_fence_destroy(struct vmw_fence_obj *fence)

{

	struct vmw_fence_manager *fman = fman_from_fence(fence);



	fence_free(&fence->base);



	/*

	 * Free kernel space accounting.

	 */

	ttm_mem_global_free(vmw_mem_glob(fman->dev_priv),

			    fman->fence_size);

}



int vmw_fence_create(struct vmw_fence_manager *fman,

		     uint32_t seqno,

		     struct vmw_fence_obj **p_fence)

{

	struct ttm_mem_global *mem_glob = vmw_mem_glob(fman->dev_priv);

	struct vmw_fence_obj *fence;

	int ret;



	ret = ttm_mem_global_alloc(mem_glob, fman->fence_size,

				   false, false);

	if (unlikely(ret != 0))

		return ret;



	fence = kzalloc(sizeof(*fence), GFP_KERNEL);

	if (unlikely(fence == NULL)) {

		ret = -ENOMEM;

		goto out_no_object;

	}

	if (unlikely(fence == NULL))

		return -ENOMEM;



	ret = vmw_fence_obj_init(fman, fence, seqno,

				 vmw_fence_destroy);
@@ -585,8 +569,6 @@ int vmw_fence_create(struct vmw_fence_manager *fman, 


out_err_init:

	kfree(fence);

out_no_object:

	ttm_mem_global_free(mem_glob, fman->fence_size);

	return ret;

}