Commit 1f0b030c authored Sep 01, 2014 by Sebastian Herbszt Committed by Nicholas Bellinger Sep 17, 2014

target: Fix inverted logic in SE_DEV_ALUA_SUPPORT_STATE_STORE



Fix inverted logic in SE_DEV_ALUA_SUPPORT_STATE_STORE for setting
the supported ALUA access states via configfs, originally introduced
in commit b0a382c5.

A value of 1 should enable the support, not disable it.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Cc: <stable@vger.kernel.org> # v3.14+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 096b4995

drivers/target/target_core_configfs.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2363,7 +2363,7 @@ static ssize_t target_core_alua_tg_pt_gp_store_attr_alua_support_##_name(\
	pr_err("Invalid value '%ld', must be '0' or '1'\n", tmp); \		pr_err("Invalid value '%ld', must be '0' or '1'\n", tmp); \
	return -EINVAL; \		return -EINVAL; \
	} \		} \
	if (!tmp) \		if (tmp) \
	t->_var \|= _bit; \		t->_var \|= _bit; \
	else \		else \
	t->_var &= ~_bit; \		t->_var &= ~_bit; \