Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f023297 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Wolfram Sang
Browse files

i2c: slave eeprom: clean up sysfs bin attribute read()/write() 



The change removes redundant sysfs binary file boundary checks,
since this task is already done on caller side in fs/sysfs/file.c

Note, on file size overflow read() now returns 0, and this is a
correct and expected EOF notification according to POSIX.

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent bc0195aa

drivers/i2c/i2c-slave-eeprom.c

+0 −6
Original line number Diff line number Diff line
@@ -80,9 +80,6 @@ static ssize_t i2c_slave_eeprom_bin_read(struct file *filp, struct kobject *kobj 
	struct eeprom_data *eeprom;

	unsigned long flags;



	if (off + count > attr->size)

		return -EFBIG;



	eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj));



	spin_lock_irqsave(&eeprom->buffer_lock, flags);
@@ -98,9 +95,6 @@ static ssize_t i2c_slave_eeprom_bin_write(struct file *filp, struct kobject *kob 
	struct eeprom_data *eeprom;

	unsigned long flags;



	if (off + count > attr->size)

		return -EFBIG;



	eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj));



	spin_lock_irqsave(&eeprom->buffer_lock, flags);