Commit 1ed3f8ce authored Sep 11, 2014 by Axel Lin Committed by Mark Brown Sep 12, 2014

regulator: rk808: Fix missing of_node_put



1. Pass &pdev->dev rather than &client->dev to of_regulator_match, the *dev
   argument is used for devres to ensure devm_of_regulator_put_matches() will
   be called when unload the module.

2. of_get_child_by_name() returns a node pointer with refcount incremented.
   Thus add missing of_node_put(reg_np).

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 1f0c0162

drivers/regulator/rk808-regulator.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -281,8 +281,9 @@ static int rk808_regulator_probe(struct platform_device *pdev)
		if (!reg_np)
		return -ENXIO;

		ret = of_regulator_match(&client->dev, reg_np, rk808_reg_matches,
		ret = of_regulator_match(&pdev->dev, reg_np, rk808_reg_matches,
		RK808_NUM_REGULATORS);
		of_node_put(reg_np);
		if (ret < 0)
		return ret;