Commit 1e6c22ae authored Jul 19, 2017 by Colin Ian King Committed by David S. Miller Jul 19, 2017

net: tehuti: don't process data if it has not been copied from userspace

The array data is only populated with valid information from userspace
if cmd != SIOCDEVPRIVATE, other cases the array contains garbage on
the stack. The subsequent switch statement acts on a subcommand in
data[0] which could be any garbage value if cmd is SIOCDEVPRIVATE which
seems incorrect to me. Instead, just return EOPNOTSUPP for the case
where cmd == SIOCDEVPRIVATE to avoid this issue.

As a side note, I suspect that the original intention of the code
was for this ioctl to work just for cmd == SIOCDEVPRIVATE (and the
current logic is reversed). However, I don't wont to change the current
semantics in case any userspace code relies on this existing behaviour.

Detected by CoverityScan, CID#139647 ("Uninitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3753654e

drivers/net/ethernet/tehuti/tehuti.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -654,6 +654,8 @@ static int bdx_ioctl_priv(struct net_device ndev, struct ifreq ifr, int cmd)
		RET(-EFAULT);
		}
		DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
		} else {
		return -EOPNOTSUPP;
		}

		if (!capable(CAP_SYS_RAWIO))