Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e45a6f9 authored by Randy Dunlap's avatar Randy Dunlap Committed by Greg Kroah-Hartman
Browse files

wifi: airo: avoid uninitialized warning in airo_get_rate() 



[ Upstream commit 9373771aaed17f5c2c38485f785568abe3a9f8c1 ]

Quieten a gcc (11.3.0) build error or warning by checking the function
call status and returning -EBUSY if the function call failed.
This is similar to what several other wireless drivers do for the
SIOCGIWRATE ioctl call when there is a locking problem.

drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/39abf2c7-24a-f167-91da-ed4c5435d1c4@linux-m68k.org
Link: https://lore.kernel.org/r/20230709133154.26206-1-rdunlap@infradead.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent df62fdcd

drivers/net/wireless/cisco/airo.c

+4 −1
Original line number Diff line number Diff line
@@ -6100,8 +6100,11 @@ static int airo_get_rate(struct net_device *dev, 
{

	struct airo_info *local = dev->ml_priv;

	StatusRid status_rid;		/* Card status info */

	int ret;



	readStatusRid(local, &status_rid, 1);

	ret = readStatusRid(local, &status_rid, 1);

	if (ret)

		return -EBUSY;



	vwrq->value = le16_to_cpu(status_rid.currentXmitRate) * 500000;

	/* If more than one rate, set auto */