Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e421be1 authored by Suzuki K Poulose's avatar Suzuki K Poulose Committed by Yabin Cui
Browse files

UPSTREAM: coresight: Fix freeing up the coresight connections 



(Upstream commit 1b015ef28a443a89985db2a67080bf7c660d66d2).

With commit c2c729415b2d2132 ("coresight: platform: Cleanup coresight
connection handling"), we switched to re-using coresight_connections
for the coresight_device. However, that introduced a mismatch in the
alloc/free of the connections. The allocation is made using devm_*,
while we use kfree() to release the memory when a device is released
(even though we don't support this at the moment). Fix this by leaving
it to the automatic freeing of the memory.

Fixes: c2c729415b2d2132 ("coresight: platform: Cleanup coresight connection handling")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Bug: 140266694
Change-Id: If5226ef45073cc1a450d3e98fc1f91f9ed86a2f4
Signed-off-by: default avatarYabin Cui <yabinc@google.com>
parent 3f2c1cc5

drivers/hwtracing/coresight/coresight.c

+0 −1
Original line number Diff line number Diff line
@@ -973,7 +973,6 @@ static void coresight_device_release(struct device *dev) 
{

	struct coresight_device *csdev = to_coresight_device(dev);



	kfree(csdev->conns);

	kfree(csdev->refcnt);

	kfree(csdev);

}