Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1db9b1bf authored by Yunsheng Lin's avatar Yunsheng Lin Committed by David S. Miller
Browse files

net: hns3: Cleanup for non-static function in hns3 driver 



This patch fixes the following warning from sparse:
warning: symbol 'hns3_set_multicast_list' was not declared.
Should it be static.

hns3_set_multicast_list turns out to be not used, so delete it.

Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a90bb9a5

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

+2 −2
Original line number Diff line number Diff line
@@ -276,8 +276,8 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num) 
	return retval;

}



enum hclge_cmd_status hclge_cmd_query_firmware_version(struct hclge_hw *hw,

						       u32 *version)

static enum hclge_cmd_status hclge_cmd_query_firmware_version(

		struct hclge_hw *hw, u32 *version)

{

	struct hclge_query_version_cmd *resp;

	struct hclge_desc desc;

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+7 −7
Original line number Diff line number Diff line
@@ -1550,7 +1550,7 @@ static int hclge_tx_buffer_calc(struct hclge_dev *hdev, 
 * @buf_alloc: pointer to buffer calculation data

 * @return: 0: calculate sucessful, negative: fail

 */

int hclge_rx_buffer_calc(struct hclge_dev *hdev,

static int hclge_rx_buffer_calc(struct hclge_dev *hdev,

				struct hclge_pkt_buf_alloc *buf_alloc)

{

	u32 rx_all = hdev->pkt_buf_size;
@@ -2828,8 +2828,8 @@ int hclge_map_vport_ring_to_vector(struct hclge_vport *vport, int vector_id, 
	return 0;

}



int hclge_map_handle_ring_to_vector(struct hnae3_handle *handle,

				    int vector,

static int hclge_map_handle_ring_to_vector(

		struct hnae3_handle *handle, int vector,

		struct hnae3_ring_chain_node *ring_chain)

{

	struct hclge_vport *vport = hclge_get_vport(handle);
@@ -3206,7 +3206,7 @@ static void hclge_prepare_mac_addr(struct hclge_mac_vlan_tbl_entry_cmd *new_req, 
	new_req->mac_addr_lo16 = cpu_to_le16(low_val & 0xffff);

}



u16 hclge_get_mac_addr_to_mta_index(struct hclge_vport *vport,

static u16 hclge_get_mac_addr_to_mta_index(struct hclge_vport *vport,

					   const u8 *addr)

{

	u16 high_val = addr[1] | (addr[0] << 8);

drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c

+4 −16
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ 
#include "hnae3.h"

#include "hns3_enet.h"



const char hns3_driver_name[] = "hns3";

static const char hns3_driver_name[] = "hns3";

const char hns3_driver_version[] = VERMAGIC_STRING;

static const char hns3_driver_string[] =

			"Hisilicon Ethernet Network Driver for Hip08 Family";
@@ -304,18 +304,6 @@ static int hns3_nic_net_stop(struct net_device *netdev) 
	return 0;

}



void hns3_set_multicast_list(struct net_device *netdev)

{

	struct hnae3_handle *h = hns3_get_handle(netdev);

	struct netdev_hw_addr *ha = NULL;



	if (h->ae_algo->ops->set_mc_addr) {

		netdev_for_each_mc_addr(ha, netdev)

			if (h->ae_algo->ops->set_mc_addr(h, ha->addr))

				netdev_err(netdev, "set multicast fail\n");

	}

}



static int hns3_nic_uc_sync(struct net_device *netdev,

			    const unsigned char *addr)

{
@@ -360,7 +348,7 @@ static int hns3_nic_mc_unsync(struct net_device *netdev, 
	return 0;

}



void hns3_nic_set_rx_mode(struct net_device *netdev)

static void hns3_nic_set_rx_mode(struct net_device *netdev)

{

	struct hnae3_handle *h = hns3_get_handle(netdev);
@@ -2596,7 +2584,7 @@ static void hns3_fini_ring(struct hns3_enet_ring *ring) 
	ring->next_to_use = 0;

}



int hns3_buf_size2type(u32 buf_size)

static int hns3_buf_size2type(u32 buf_size)

{

	int bd_size_type;
@@ -2908,7 +2896,7 @@ static int hns3_client_setup_tc(struct hnae3_handle *handle, u8 tc) 
	return ret;

}



const struct hnae3_client_ops client_ops = {

static const struct hnae3_client_ops client_ops = {

	.init_instance = hns3_client_init,

	.uninit_instance = hns3_client_uninit,

	.link_status_change = hns3_link_status_change,

drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -215,8 +215,8 @@ static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data) 
 * @stats: statistics info.

 * @data: statistics data.

 */

void hns3_get_stats(struct net_device *netdev, struct ethtool_stats *stats,

		    u64 *data)

static void hns3_get_stats(struct net_device *netdev,

			   struct ethtool_stats *stats, u64 *data)

{

	struct hnae3_handle *h = hns3_get_handle(netdev);

	u64 *p = data;