Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d15bd20 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: fix memory leak after kobject init failed in fill_super 



If we failed to init&add kobject when fill_super, stats info and proc object of
f2fs will not be released.
We should free them before we finish fill_super.

Signed-off-by: default avatarChao Yu <chao2.yu@samsung.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk.kim@samsung.com>
parent fb51b5ef

fs/f2fs/super.c

+8 −2
Original line number Diff line number Diff line
@@ -975,12 +975,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) 
		/* After POR, we can run background GC thread.*/

		err = start_gc_thread(sbi);

		if (err)

			goto fail;

			goto free_gc;

	}



	err = f2fs_build_stats(sbi);

	if (err)

		goto fail;

		goto free_gc;



	if (f2fs_proc_root)

		sbi->s_proc = proc_mkdir(sb->s_id, f2fs_proc_root);
@@ -1006,6 +1006,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) 


	return 0;

fail:

	if (sbi->s_proc) {

		remove_proc_entry("segment_info", sbi->s_proc);

		remove_proc_entry(sb->s_id, f2fs_proc_root);

	}

	f2fs_destroy_stats(sbi);

free_gc:

	stop_gc_thread(sbi);

free_root_inode:

	dput(sb->s_root);