Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c55053c authored by Alexey Starikovskiy's avatar Alexey Starikovskiy Committed by Len Brown
Browse files

ACPI: EC: Don't re-enable GPE for each transaction. 

With the auto selection of operation mode, absence of GPEs does not
really degrade performance, so let PM code to handle
enabling/disabling GPEs.
This is a revert of 5d57a6a5,
which was meant to be temporary.

Reference: http://bugzilla.kernel.org/show_bug.cgi?id=7977



Signed-off-by: default avatarAlexey Starikovskiy <astarikovskiy@suse.de>
Acked-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 7843932a

drivers/acpi/ec.c

+0 −5
Original line number Diff line number Diff line
@@ -258,9 +258,6 @@ static int acpi_ec_transaction(struct acpi_ec *ec, u8 command, 
		}

	}



	/* Make sure GPE is enabled before doing transaction */

	acpi_enable_gpe(NULL, ec->gpe, ACPI_NOT_ISR);



	status = acpi_ec_wait(ec, ACPI_EC_EVENT_IBF_0, 0);

	if (status) {

		printk(KERN_ERR PREFIX
@@ -638,12 +635,10 @@ static struct acpi_ec *make_acpi_ec(void) 
	struct acpi_ec *ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);

	if (!ec)

		return NULL;



	ec->flags = 1 << EC_FLAGS_QUERY_PENDING;

	mutex_init(&ec->lock);

	init_waitqueue_head(&ec->wait);

	INIT_LIST_HEAD(&ec->list);



	return ec;

}