Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c176d53 authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: rcar: not everything needs to be a function 



Very basic operations, just called once, can also go to the caller.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 90104d06

drivers/i2c/busses/i2c-rcar.c

+3 −11
Original line number Diff line number Diff line
@@ -312,18 +312,9 @@ static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv, 
	return 0;

}



static void rcar_i2c_clock_start(struct rcar_i2c_priv *priv)

{

	rcar_i2c_write(priv, ICCCR, priv->icccr);

}



/*

 *		status functions

 */

static u32 rcar_i2c_status_get(struct rcar_i2c_priv *priv)

{

	return rcar_i2c_read(priv, ICMSR);

}



#define rcar_i2c_status_clear(priv) rcar_i2c_status_bit_clear(priv, 0xffffffff)

static void rcar_i2c_status_bit_clear(struct rcar_i2c_priv *priv, u32 bit)
@@ -480,7 +471,7 @@ static irqreturn_t rcar_i2c_irq(int irq, void *ptr) 
	/*-------------- spin lock -----------------*/

	spin_lock(&priv->lock);



	msr = rcar_i2c_status_get(priv);

	msr = rcar_i2c_read(priv, ICMSR);



	/*

	 * Arbitration lost
@@ -554,7 +545,8 @@ static int rcar_i2c_master_xfer(struct i2c_adapter *adap, 
	spin_lock_irqsave(&priv->lock, flags);



	rcar_i2c_init(priv);

	rcar_i2c_clock_start(priv);

	/* start clock */

	rcar_i2c_write(priv, ICCCR, priv->icccr);



	spin_unlock_irqrestore(&priv->lock, flags);

	/*-------------- spin unlock -----------------*/