Commit 1b8dd2d6 authored Jan 05, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 17, 2021

regmap: debugfs: Fix a reversed if statement in regmap_debugfs_init()



commit f6bcb4c7f366905b66ce8ffca7190118244bb642 upstream.

This code will leak "map->debugfs_name" because the if statement is
reversed so it only frees NULL pointers instead of non-NULL.  In
fact the if statement is not required and should just be removed
because kfree() accepts NULL pointers.

Fixes: cffa4b2122f5 ("regmap: debugfs: Fix a memory leak when calling regmap_attach_dev")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X/RQpfAwRdLg0GqQ@mwanda


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 77ca19cf

drivers/base/regmap/regmap-debugfs.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -591,9 +591,7 @@ void regmap_debugfs_init(struct regmap map, const char name)
		}

		if (!strcmp(name, "dummy")) {
		if (!map->debugfs_name)
		kfree(map->debugfs_name);

		map->debugfs_name = kasprintf(GFP_KERNEL, "dummy%d",
		dummy_index);
		if (!map->debugfs_name)