Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b807e10 authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman
Browse files

Drivers: hv: vmbus: Cleanup vmbus_set_event() 



Cleanup vmbus_set_event() by inlining the hypercall to post
the event and since the return value of vmbus_set_event() is not checked,
make it void. As part of this cleanup, get rid of the function
hv_signal_event() as it is only callled from vmbus_set_event().

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5fae054c

drivers/hv/connection.c

+2 −2
Original line number Diff line number Diff line
@@ -474,7 +474,7 @@ int vmbus_post_msg(void *buffer, size_t buflen) 
/*

 * vmbus_set_event - Send an event notification to the parent

 */

int vmbus_set_event(struct vmbus_channel *channel)

void vmbus_set_event(struct vmbus_channel *channel)

{

	u32 child_relid = channel->offermsg.child_relid;
@@ -485,5 +485,5 @@ int vmbus_set_event(struct vmbus_channel *channel) 
			(child_relid >> 5));

	}



	return hv_signal_event(channel->sig_event);

	hv_do_hypercall(HVCALL_SIGNAL_EVENT, channel->sig_event, NULL);

}

drivers/hv/hv.c

+0 −16
Original line number Diff line number Diff line
@@ -337,22 +337,6 @@ int hv_post_message(union hv_connection_id connection_id, 
	return status & 0xFFFF;

}





/*

 * hv_signal_event -

 * Signal an event on the specified connection using the hypervisor event IPC.

 *

 * This involves a hypercall.

 */

int hv_signal_event(void *con_id)

{

	u64 status;



	status = hv_do_hypercall(HVCALL_SIGNAL_EVENT, con_id, NULL);



	return status & 0xFFFF;

}



static int hv_ce_set_next_event(unsigned long delta,

				struct clock_event_device *evt)

{

drivers/hv/hyperv_vmbus.h

+1 −3
Original line number Diff line number Diff line
@@ -501,8 +501,6 @@ extern int hv_post_message(union hv_connection_id connection_id, 
			 enum hv_message_type message_type,

			 void *payload, size_t payload_size);



extern int hv_signal_event(void *con_id);



extern int hv_synic_alloc(void);



extern void hv_synic_free(void);
@@ -650,7 +648,7 @@ void vmbus_disconnect(void); 


int vmbus_post_msg(void *buffer, size_t buflen);



int vmbus_set_event(struct vmbus_channel *channel);

void vmbus_set_event(struct vmbus_channel *channel);



void vmbus_on_event(unsigned long data);