Commit 1af92e2a authored Sep 05, 2009 by Yevgeny Petrilin Committed by Roland Dreier Sep 05, 2009

mlx4_core: Avoid double free_icms



On the error path of mlx4_init_hca(), mlx4_close_hca() is called,
followed by mlx4_free_icms() and mlx4_UNMAP_FA().  But both those
functions are also called from mlx4_close_hca(), which leads to a
double free.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent fa0681d2

drivers/net/mlx4/main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -789,7 +789,7 @@ static int mlx4_init_hca(struct mlx4_dev *dev)
		return 0;

		err_close:
		mlx4_close_hca(dev);
		mlx4_CLOSE_HCA(dev, 0);

		err_free_icm:
		mlx4_free_icms(dev);